fix: stale HTTPRoute/GRPCRoute/TLSRoute/TCPRoute/UDPRoute status after gateway-only spec changes by yuehaii · Pull Request #8876 · envoyproxy/gateway

yuehaii · 2026-04-28T04:25:49Z

What type of PR is this?
fix: stale HTTPRoute/GRPCRoute/TLSRoute/TCPRoute/UDPRoute/ status after gateway-only spec changes

Issue description
When a Gateway resource is updated without touching any Route resource (e.g. a listener hostname or allowedRoutes change), the Route's status.parents[*].conditions become stale, the observedGeneration field continues pointing at the old gateway generation instead of the new one.

Root cause
The bug only manifests as False→False (same outcome, only ObservedGeneration should advance). If the gateway update trigger a new route reconcile, GetGeneration() hasn't changed because the route was not modified. So the newly computed condition is byte-for-byte identical to what's already in the store and never trigger the status update.

Fix
Fixed the conformance test failure, by embed the gateway's generation into the 'Message' field. This guarantees that any gateway update produces a different 'Message' string, which breaks the DeepEqual gate

Verification

unit test

go test ./internal/gatewayapi/runner/... -v -run "TestHTTPRouteStatusStaleAfterAllowedRoutesChange" -count=1 2>&1 | tail -15
=== RUN TestHTTPRouteStatusStaleAfterAllowedRoutesChange
--- PASS: TestHTTPRouteStatusStaleAfterAllowedRoutesChange (0.15s)
PASS
1.777439888886663e+09 info gateway-api runner/runner.go:557 shutting down {"runner": "gateway-api"}
ok github.com/envoyproxy/gateway/internal/gatewayapi/runner 1.612s

go test ./internal/gatewayapi/runner/... -v -run TestHTTPRouteStatusStaleAfterListenerHostnameChange -count=1 2>&1 | tail -50
=== RUN TestHTTPRouteStatusStaleAfterListenerHostnameChange
--- PASS: TestHTTPRouteStatusStaleAfterListenerHostnameChange (0.15s)
PASS
1.7774398311383302e+09 info gateway-api runner/runner.go:557 shutting down {"runner": "gateway-api"}
ok github.com/envoyproxy/gateway/internal/gatewayapi/runner 1.663s

integration test

Step 1 — Bug Reproduction (unpatched controller)

Setup: Gateway listener on other.example.com, HTTPRoute hostname test.example.com (no match).

Step Gateway gen Accepted condition observedGeneration

Create gateway + route 1 False / NoMatchingListenerHostname 1

Add matching listener (gateway-only edit) 2 False / NoMatchingListenerHostname ❌ (stale — should be True) still 1 ❌

Step 2 — Fix Verification (patched controller)

Step Gateway gen Accepted condition observedGeneration

Reset: only other.example.com listener 3 False / NoMatchingListenerHostname 3

Add another.example.com (same False outcome, only gen changes) 4 False / NoMatchingListenerHostname 4 ✅

Add matching test.example.com listener 5 True / Accepted 5 ✅

Which issue(s) this PR fixes:
Fixes #8861

Release Notes: Yes

netlify · 2026-04-28T04:25:55Z

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name	Link
🔨 Latest commit	`4f4d7bf`
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a491bd622791f00085ae52e
😎 Deploy Preview	https://deploy-preview-8876--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f6c48c111

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

yuehaii · 2026-05-08T01:28:47Z

hi @zirain @zhaohuabing @rudrakhp . Good day. I am not sure who is the maintainer of the related code in this pr. Can you please help review this pr when you are convenient? Thanks in advance.

zirain · 2026-05-08T01:38:21Z

+		// For gateway-driven conditions, use the Gateway's generation as observedGeneration
+		// Gateway-only edit produces a condition value that differs
+		// from the stale stored one, unblocking the watchable DeepEqual gate.
+		observedGeneration := httpRoute.GetGeneration()


a route may have multiple parents, what will happen then?

each parent's generation will be updated into the store's watchable map. so if there is one parent gateway generation change, it will trigger the route status update event.

codecov · 2026-05-08T01:40:50Z

Codecov Report

❌ Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.64%. Comparing base (4eb8bb6) to head (4f4d7bf).
⚠️ Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/gatewayapi/helpers.go	0.00%	5 Missing ⚠️
internal/gatewayapi/route.go	89.47%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8876      +/-   ##
==========================================
+ Coverage   75.20%   75.64%   +0.44%     
==========================================
  Files         252      252              
  Lines       41049    41483     +434     
==========================================
+ Hits        30871    31380     +509     
+ Misses       8086     7945     -141     
- Partials     2092     2158      +66

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yuehaii · 2026-05-08T05:48:09Z

working on the conformance test failure

yuehaii · 2026-05-11T01:28:25Z

I have fixed the conformance test failure, by embed the gateway's generation into the 'Message' field. @zirain , can you please help review again? this guarantees that any gateway update produces a different 'Message' string, which breaks the DeepEqual gate at

gateway/internal/gatewayapi/status/conditions.go

Line 39 in cbb4337

if !reflect.DeepEqual(conditions[j], update) {

zirain · 2026-05-11T02:03:09Z

can you fix the conlict and add a e2e for this?

arkodg · 2026-05-11T02:12:34Z

this is a bug, but the fix doesnt look right

if a Gateway does not attach to a Route anymore, Envoy Gateway should remove any status created by it

We delete status keys in

gateway/internal/gatewayapi/runner/runner.go

Line 620 in cbb4337

// Delete status keys

but we dont update status for it

gateway/internal/provider/kubernetes/status.go

Line 95 in cbb4337

if update.Delete {

this is something we should do in the provider layer

yuehaii · 2026-05-11T03:49:55Z

this is a bug, but the fix doesnt look right

if a Gateway does not attach to a Route anymore, Envoy Gateway should remove any status created by it

We delete status keys in

gateway/internal/gatewayapi/runner/runner.go

Line 620 in cbb4337

// Delete status keys

but we dont update status for it

gateway/internal/provider/kubernetes/status.go

Line 95 in cbb4337

if update.Delete {

this is something we should do in the provider layer

thanks for the input. when the gateway's host is updated, the subscription will receives an update with update.Delete = false. so the 'update.Delete == true' seems unrelated with normal reconcile issue for any normal gateway update.

the 'update.Delete' is set to true only when an entry is explicitly removed from the map, e.g. route deleted from cluster. as you indicated, this happens only in deleteAllKeys() when 'r.ProviderResources.ListenerSetStatuses.Delete(key)' been called.

please let me know if I miss anything.

yuehaii · 2026-05-12T14:41:06Z

I added an e2e test. But it always PASS even without the fix.

go test -v -tags e2e -timeout 10m ./e2e --gateway-class=envoy-gateway -run-test HTTPRouteStaleStatus
….
--- PASS: TestE2E/HTTPRouteStaleStatus (3.38s)
--- PASS: TestE2E/HTTPRouteStaleStatus/route_initially_rejected_due_to_hostname_mismatch (0.24s)
--- PASS: TestE2E/HTTPRouteStaleStatus/gateway_updated_to_add_matching_listener (0.48s)
--- PASS: TestE2E/HTTPRouteStaleStatus/route_status_updated_to_Accepted=True_after_gateway_change (0.24s)
--- PASS: TestE2E/HTTPRouteStaleStatus/condition_message_contains_gateway_generation (0.48s)

I launched the integration test again with envoy-gateway v1.7.0. But I can't reproduce the issue.
After adding one more listener marching the http route hostname. The http route status been updated as expected.

kubectl get HTTPRoute -A
	NAMESPACE              NAME               HOSTNAMES                 AGE
	envoy-gateway-system   no-match-route-1   ["route-1.example.com"]   78s
	envoy-gateway-system   no-match-route-2   ["route-2.example.com"]   78s
	envoy-gateway-system   no-match-route-3   ["route-3.example.com"]   77s
	envoy-gateway-system   no-match-route-4   ["route-4.example.com"]   77s
	envoy-gateway-system   no-match-route-5   ["route-5.example.com"]   76s

// before updating the listener
kubectl get gateway multi-listener-gw -n envoy-gateway-system -o jsonpath='{range .spec.listeners[*]}name={.name} port={.port} protocol={.protocol} hostname={.hostname}{"\n"}{end}' 
	name=listener-a port=8880 protocol=HTTP hostname=listener-a.example.com
	name=listener-b port=8881 protocol=HTTP hostname=listener-b.example.com
	name=listener-c port=8882 protocol=HTTP hostname=listener-c.example.com
kubectl describe HTTPRoute no-match-route-1 -n envoy-gateway-system 
	Name:         no-match-route-1
	Namespace:    envoy-gateway-system
	Labels:       <none>
	Annotations:  <none>
	API Version:  gateway.networking.k8s.io/v1
	Kind:         HTTPRoute
	Metadata:
	  Creation Timestamp:  2026-05-12T01:56:13Z
	  Generation:          1
	  Resource Version:    153153
	  UID:                 d7cc4ac3-1458-430a-895f-5ee0c18fef60
	Spec:
	  Hostnames:
	    route-1.example.com
	  Parent Refs:
	    Group:  gateway.networking.k8s.io
	    Kind:   Gateway
	    Name:   multi-listener-gw
	  Rules:
	    Backend Refs:
	      Group:   
	      Kind:    Service
	      Name:    envoy-gateway
	      Port:    80
	      Weight:  1
	    Matches:
	      Path:
	        Type:   PathPrefix
	        Value:  /route-1
	Status:
	  Parents:
	    Conditions:
	      Last Transition Time:  2026-05-12T01:56:13Z
	      Message:               There were no hostname intersections between the HTTPRoute and this parent ref's Listener(s).
	      Observed Generation:   1
	      Reason:                NoMatchingListenerHostname
	      Status:                False
	      Type:                  Accepted
	      Last Transition Time:  2026-05-12T01:56:13Z
	      Message:               Failed to process route rule 0 backendRef 0: TCP Port 80 not found on Service envoy-gateway-system/envoy-gateway.
	      Observed Generation:   1
	      Reason:                PortNotFound
	      Status:                False
	      Type:                  ResolvedRefs
	    Controller Name:         gateway.envoyproxy.io/gatewayclass-controller
	    Parent Ref:
	      Group:  gateway.networking.k8s.io
	      Kind:   Gateway
	      Name:   multi-listener-gw
	Events:       <none>

// after listener been updated
kubectl get gateway multi-listener-gw -n envoy-gateway-system -o jsonpath='{range .spec.listeners[*]}name={.name} port={.port} protocol={.protocol} hostname={.hostname}{"\n"}{end}' 
	name=listener-route-1 port=8880 protocol=HTTP hostname=route-1.example.com
	name=listener-a port=8880 protocol=HTTP hostname=listener-a.example.com
	name=listener-b port=8881 protocol=HTTP hostname=listener-b.example.com
	name=listener-c port=8882 protocol=HTTP hostname=listener-c.example.com
kubectl describe HTTPRoute no-match-route-1 -n envoy-gateway-system 
	Name:         no-match-route-1
	Namespace:    envoy-gateway-system
	Labels:       <none>
	Annotations:  <none>
	API Version:  gateway.networking.k8s.io/v1
	Kind:         HTTPRoute
	Metadata:
	  Creation Timestamp:  2026-05-12T01:56:13Z
	  Generation:          1
	  Resource Version:    155492
	  UID:                 d7cc4ac3-1458-430a-895f-5ee0c18fef60
	Spec:
	  Hostnames:
	    route-1.example.com
	  Parent Refs:
	    Group:  gateway.networking.k8s.io
	    Kind:   Gateway
	    Name:   multi-listener-gw
	  Rules:
	    Backend Refs:
	      Group:   
	      Kind:    Service
	      Name:    envoy-gateway
	      Port:    80
	      Weight:  1
	    Matches:
	      Path:
	        Type:   PathPrefix
	        Value:  /route-1
	Status:
	  Parents:
	    Conditions:
	      Last Transition Time:  2026-05-12T02:01:14Z
	      Message:               Route is accepted
	      Observed Generation:   1
	      Reason:                Accepted
	      Status:                True
	      Type:                  Accepted
	      Last Transition Time:  2026-05-12T02:01:14Z
	      Message:               Failed to process route rule 0 backendRef 0: TCP Port 80 not found on Service envoy-gateway-system/envoy-gateway.
	      Observed Generation:   1
	      Reason:                PortNotFound
	      Status:                False
	      Type:                  ResolvedRefs
	    Controller Name:         gateway.envoyproxy.io/gatewayclass-controller
	    Parent Ref:
	      Group:  gateway.networking.k8s.io
	      Kind:   Gateway
	      Name:   multi-listener-gw
	Events:       <none>

github-actions · 2026-06-11T17:12:06Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

zirain · 2026-06-18T22:56:11Z

@yuehaii can you rebase this one with main?

zirain · 2026-06-23T03:05:45Z

can you rebase with main correctly, I think that would also make the DCO happy.

…r gateway-only spec changes Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

…edGeneration Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

…th sequential chaining (envoyproxy#8458) * feat: add support for multiple ExtensionManagers with sequential chaining Add a new `extensionManagers` plural field to `EnvoyGatewaySpec` that allows registering multiple extension managers with sequential chaining semantics. Each extension's output becomes the next extension's input. Key changes: - Add `Name` field to `ExtensionManager` and `ExtensionManagers` list to `EnvoyGatewaySpec` - Add `GetExtensionManagers()` helper to normalize singular/plural fields - Add mutual exclusivity validation between singular and plural fields - Implement `CompositeManager` wrapping multiple managers behind the `Manager` interface - Implement `compositeXDSHookClient` with per-extension policy filtering and per-extension resource-type gating in `PostTranslateModifyHook` - Merge `TranslationConfig` using OR semantics across all managers - Add `CleanupHookConns()` to the `Manager` interface - Unify `NewManager` factory to handle 0, 1, and N extensions Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Fix lint issues Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Add more test cases Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Per-extension manager filter Resources, BackendResources, and PolicyResources accordingly Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Implement new hook method PostEndpointsModifyHook Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Respect failOpen when GetPre/PostXDSHookClient errors in CompositeManager Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Simplified and unified client getter and tests Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Add resilience tests for multiple ExtensionManagers chaining and resource isolation Enhance the simple-extension-server with a configurable --suffix flag and resource-aware PostRouteModify to support testing multiple extension managers. Add resilience tests that verify sequential chaining of VirtualHost mutations and per-extension resource isolation via extensionRef filters. Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Add CompositeManager coverage to xDS translator tests and document plural ExtensionManagers Mirror the existing extension-manager translator error-handling tests through CompositeManager via a new NewInMemoryCompositeManager helper: a 1-entry composite verifies child errors are swallowed when failOpen is true, and a 2-entry composite verifies errors are propagated with the 'extension "<name>":' prefix when failOpen is false. Extract a shared buildManagerGVKSets helper to avoid duplication between NewManager and the new in-memory constructor. Also extend the extension-server docs with a "Multiple extension servers" subsection covering sequential chaining, per-server resource isolation, per-server failOpen, the unique name requirement, and mutual exclusivity with the singular extensionManager field. Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Fix lint errors Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Match extension resources by group/kind, and wire cleanup for in-memory composite Two fixes in the composite-extension path: 1. CompositeManager filter now matches by group/kind only, aligning with runner.ExtensionGroupKinds, Manager.HasExtension, and Gateway API extensionRef. Exact-GVK matching could silently drop resources whose served version differed from the one declared in ExtensionManager.Resources, diverging from single-manager behavior when CRDs serve multiple versions. 2. NewInMemoryCompositeManager wires a sync.Once-guarded cleanup into every entry's cleanupHookConn, so CompositeManager.CleanupHookConns() (from the Manager interface) tears down the shared bufconn/server. The separate cleanup func return is removed; callers use CleanupHookConns() on the returned Manager. Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Add MinItems=1 and mutual-exclusion validation on extensionManagers * +kubebuilder:validation:MinItems=1 on EnvoyGatewaySpec.ExtensionManagers, mirrored by a runtime check that rejects an explicitly-set-but-empty list (a nil slice still means "omitted"). * +kubebuilder:validation:XValidation on EnvoyGatewaySpec declaring that extensionManager and extensionManagers are mutually exclusive. The same constraint is already enforced at runtime in validateEnvoyGatewayExtensionManagers; the marker documents the schema and is wired up for consumers that validate against the generated OpenAPI. Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> * Fix MultiextensionManagers tests Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> --------- Signed-off-by: Marc Navarro Sonnenfeld <marcnavarro@tetrate.io> Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

* feat: bandwidth limit Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add: crd validation Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com> Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

…uld check the 'no ready listeners' status. Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

…est case with NoReadyListeners reason Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

yuehaii · 2026-06-26T03:25:26Z

error: Get "http://172.18.0.205:8080/bar": dial tcp 172.18.0.205:8080: connect: connection refused, not counting the round trip

/retest

yuehaii · 2026-06-30T02:20:26Z

can you rebase with main correctly, I think that would also make the DCO happy.

hi @zirain , good morning. I have rebased the code and fixed the CI failures. could you please review this pr again when it is convenient? thanks.

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

arkodg · 2026-07-05T08:14:23Z

thanks for the input. when the gateway's host is updated, the subscription will receives an update with update.Delete = false. so the 'update.Delete == true' seems unrelated with normal reconcile issue for any normal gateway update.

the 'update.Delete' is set to true only when an entry is explicitly removed from the map, e.g. route deleted from cluster. as you indicated, this happens only in deleteAllKeys() when 'r.ProviderResources.ListenerSetStatuses.Delete(key)' been called.

please let me know if I miss anything.

thanks for the correction, but this is the area of the code that needs to be fixed

gateway/internal/provider/kubernetes/status.go

Line 26 in dc73f48

    
           func (r *gatewayAPIReconciler) updateStatusFromSubscriptions(ctx context.Context, extensionManagerEnabled bool) {

yuehaii · 2026-07-07T05:17:00Z

thanks for the input. when the gateway's host is updated, the subscription will receives an update with update.Delete = false. so the 'update.Delete == true' seems unrelated with normal reconcile issue for any normal gateway update.
the 'update.Delete' is set to true only when an entry is explicitly removed from the map, e.g. route deleted from cluster. as you indicated, this happens only in deleteAllKeys() when 'r.ProviderResources.ListenerSetStatuses.Delete(key)' been called.
please let me know if I miss anything.

thanks for the correction, but this is the area of the code that needs to be fixed

gateway/internal/provider/kubernetes/status.go

Line 26 in dc73f48

func (r *gatewayAPIReconciler) updateStatusFromSubscriptions(ctx context.Context, extensionManagerEnabled bool) {

The stale status problem is that when a gateway-only change happens, the watchable DeepEqual gate suppresses the update before it even reaches updateStatusFromSubscriptions. So updateStatusFromSubscriptions in status.go never gets called.
The fix must happen before Store() is called, so the stored value differs from the previous one even when the condition outcome is the same.
The cleanest fix would be at the runner level: after translating, compare the new status with the previously stored status and if the Gateway generation increased, touch the status (e.g. set a generation aware field) to ensure DeepEqual returns false and the update flows through.

yuehaii requested a review from a team as a code owner April 28, 2026 04:25

chatgpt-codex-connector Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread internal/gatewayapi/route.go Outdated

zirain reviewed May 8, 2026

View reviewed changes

arkodg mentioned this pull request May 11, 2026

HTTPRoute status condition not refreshed when listener configuration changes (NoMatchingListenerHostname stale) #8861

Open

paulden mentioned this pull request May 26, 2026

HTTPRoute status.parents left with previous parent after changing the spec.parentRefs #9023

Open

github-actions Bot added the stale label Jun 11, 2026

github-actions Bot closed this Jun 18, 2026

zirain reopened this Jun 18, 2026

github-actions Bot removed the stale label Jun 19, 2026

yuehaii force-pushed the main branch from fc2f0d6 to 6ba64d2 Compare June 23, 2026 02:58

zirain reviewed Jun 23, 2026

View reviewed changes

Comment thread api/v1alpha1/validation/envoygateway_validate_test.go Outdated

yuehaii and others added 7 commits June 23, 2026 11:15

fix: stale HTTPRoute/GRPCRoute/TLSRoute/TCPRoute/UDPRoute status afte…

b2b2b35

…r gateway-only spec changes Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

For gateway-driven conditions, use the Gateway's generation as observ…

d1e362a

…edGeneration Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

fix conformance test failure, replace generation with message.

bbb27a6

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com> Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

add e2e test case

7cf2c55

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

reverse incorrect merge during rebase

b974462

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

add back the missing new line at the end of file

5f15b03

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

yuehaii force-pushed the main branch from e3cbfbc to 5f15b03 Compare June 23, 2026 03:17

yuehaii added 4 commits June 23, 2026 11:44

add back the missing function

d3d207f

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

update listener test cases' expected output since HasReadyListener wo…

33feff7

…uld check the 'no ready listeners' status. Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

Merge branch 'main' into main

213d6cd

update apply_a_gateway_with_conflicted_listener_and_a_httproute e2e t…

e7f3e10

…est case with NoReadyListeners reason Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

zirain reviewed Jun 26, 2026

View reviewed changes

Comment thread test/e2e/tests/merge_gateways.go Outdated

zirain reviewed Jul 3, 2026

View reviewed changes

Comment thread internal/gatewayapi/testdata/gateway-with-attached-routes.out.yaml Outdated

yuehaii added 2 commits July 4, 2026 17:43

revert no ready listers status and test cases changes

1b967e1

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

restore no ready listeners reason.

4f4d7bf

Signed-off-by: hai.yue <20416005+yuehaii@users.noreply.github.com>

yuehaii mentioned this pull request Jul 29, 2026

fix: stale route status after the parent Gateway is modified kubernetes-sigs/gateway-api#5116

Open

Step	Gateway gen	`Accepted` condition	`observedGeneration`
Create gateway + route	1	`False / NoMatchingListenerHostname`	1
Add matching listener (gateway-only edit)	2	`False / NoMatchingListenerHostname` ❌ (stale — should be True)	still 1 ❌

Step	Gateway gen	`Accepted` condition	`observedGeneration`
Reset: only `other.example.com` listener	3	`False / NoMatchingListenerHostname`	3
Add `another.example.com` (same `False` outcome, only gen changes)	4	`False / NoMatchingListenerHostname`	4 ✅
Add matching `test.example.com` listener	5	`True / Accepted`	5 ✅

Uh oh!

Conversation

yuehaii commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

yuehaii commented May 8, 2026

Uh oh!

zirain May 8, 2026

Choose a reason for hiding this comment

Uh oh!

yuehaii May 8, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yuehaii commented May 8, 2026

Uh oh!

yuehaii commented May 11, 2026

Uh oh!

zirain commented May 11, 2026

Uh oh!

arkodg commented May 11, 2026

Uh oh!

yuehaii commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuehaii commented May 12, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026

Uh oh!

zirain commented Jun 18, 2026

Uh oh!

Uh oh!

zirain commented Jun 23, 2026

Uh oh!

Uh oh!

yuehaii commented Jun 26, 2026

Uh oh!

yuehaii commented Jun 30, 2026

Uh oh!

Uh oh!

arkodg commented Jul 5, 2026

Uh oh!

yuehaii commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yuehaii commented Apr 28, 2026 •

edited

Loading

netlify Bot commented Apr 28, 2026 •

edited

Loading

codecov Bot commented May 8, 2026 •

edited

Loading

yuehaii commented May 11, 2026 •

edited

Loading

yuehaii commented Jul 7, 2026 •

edited

Loading